http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/emulators/virtualbox-ose/Makefile_DISPLAY_unsetenv.REL=8.1-RELEASE.diff http://www.freebsd.org/cgi/query-pr.cgi?pr=153557 Patch fails to apply to 8.3-RELEASE Patch fails to apply to 9.1-RELEASE but not needed & builds without patch on host=land (off site jailed host no DISPLAY set) Patch fails to apply to 9.1-RELEASE, but not needed & builds without patch on host=lapr (a local host with DISPLAY set) ---------- To: decke@@@freebsd.org Subject: Re: ports/153557: patch to warn birtualbox compiler to unsetenv DISPLAY From: "Julian H. Stacey" Organization: http://www.berklix.com BSD Unix Linux Consultancy, Munich Germany Fcc: sent User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Mon, 31 Jan 2011 10:56:21 GMT." <201101311056.p0VAuLNR078168@freefall.freebsd.org> Hi, Reference: > From: decke@@@freebsd.org > Date: Mon, 31 Jan 2011 10:56:21 GMT > Message-id: <201101311056.p0VAuLNR078168@freefall.freebsd.org> decke@@@freebsd.org wrote: > Synopsis: patch to warn birtualbox compiler to unsetenv DISPLAY > > State-Changed-From-To: open->closed > State-Changed-By: decke > State-Changed-When: Mon Jan 31 10:56:21 UTC 2011 > State-Changed-Why: > Committed. Thanks! ThAnks :-) > http://www.freebsd.org/cgi/query-pr.cgi?pr=153557 > ---------- To: FreeBSD-gnats-submit@@@freebsd.org From: "Julian H. Stacey" Reply-To: "Julian H. Stacey" Subject: Re: Checking for Mesa / GLU: X Error of failed request: BadRequest cc: Bernhard Froehlich Cc: X-send-pr-version: 3.113 X-GNATS-Notify: >Submitter-Id: current-users >Originator: "Julian H. Stacey" >Organization: http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen. >Confidential: no >Synopsis: patch to warn birtualbox compiler to unsetenv DISPLAY >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: FreeBSD 8.1-RELEASE amd64 >Environment: System: FreeBSD lapo.js.berklix.net 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Sun Aug 15 12:23:44 CEST 2010 jhs@@@lapo.js.berklix.net:/usr/src/sys/amd64/compile/LAPO.small amd64 i686 & amd64 & 8.1-RELEASE & current all show the same symptoms >Description: I was stuck by this bug till I posted & Bernhard F replied unsetenv DISPLAY, so this patch makes it easier for next person who gets stuck. It's not an ideal patch: - Its noisey, - one could add more ifdefs to avoid eg make fetch also being marked as broken, & just leave make all broken. But it does the job until someone fixes virtualbox, when the patch can then be discarded. >How-To-Repeat: setenv DISPLAY your.host.com:0 cd /usr/ports/emulators/virtualbox-ose ; make >Fix: Patch appended, also copied in http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/emulators/virtualbox-ose/Makefile_DISPLAY_unsetenv.REL=8.1-RELEASE.diff # Old patch sent with send-pr # *** old-8.1-RELEASE-and-current/ports/emulators/virtualbox-ose/Makefile Fri Dec 24 12:11:35 2010 # --- new-generic/ports/emulators/virtualbox-ose/Makefile Thu Dec 30 17:48:45 2010 # *************** # *** 20,25 **** # --- 20,30 ---- # MAINTAINER= vbox@@@FreeBSD.org # COMMENT= A general-purpose full virtualizer for x86 hardware # # + test_display != printenv DISPLAY # + .if ${test_display} != "" # + BROKEN= "unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed request: BadRequest (invalid request code or no such operation)" # + .endif # + # BUILD_DEPENDS= yasm:${PORTSDIR}/devel/yasm \ # as86:${PORTSDIR}/devel/dev86 \ # xsltproc:${PORTSDIR}/textproc/libxslt \ New patch probably better below: cc: Anonymous , bug-followup@@@FreeBSD.org, vbox@@@FreeBSD.org, Bernhard Froehlich Subject: Re: ports/153557: patch to warn birtualbox compiler to unsetenv DISPLAY From: "Julian H. Stacey" Organization: http://www.berklix.com BSD Unix Linux Consultancy, Munich Germany Fcc: sent User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Thu, 30 Dec 2010 19:41:19 +0100." "Julian H. Stacey" wrote: > Anonymous wrote: > > "Julian H. Stacey" writes: > > > > > + test_display != printenv DISPLAY > > > + .if ${test_display} != "" > > > + BROKEN= "unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed request: BadRequest (invalid request code or no such operation)" > > > + .endif > > > + > > > > assignment is redundant here, you can use value from environment directly > > > > .if defined(DISPLAY) && ${DISPLAY} != "" > > Thanks, OK I did a test 8.1-RELEASE amf64 make with DISPLAY set to null string, eg setenv DISPLAY ; make printenv | grep DISPLAY DISPLAY= Result: it builds, thus I confirm your '&& ${DISPLAY} != ""' is also appropriate, Thanks. > > I don't use the port but have you tried CONFIGURE_ARGS+=--passive-mesa ? I added CONFIGURE_ARGS+=--passive-mesa to 8.1-RELEASE i386 /usr/ports/emulators/virtualbox-ose/Makefile printenv | grep DISPLAY # DISPLAY=fire.js.berklix.net:0 Result: it builds OK. Hashing out passive-mesa, make clean ; make fails again. Conclusion: Adding CONFIGURE_ARGS+=--passive-mesa Works better avoids needing BROKEN= But what & where --passive-mesa does, I don't know & if it might damage virtualbox run time I also don't know. Hopefully vbox@@@FreeBSD.org &/or Bernhard Froehlich (cc'd) can decide that. *** old-8.1-RELEASE-and-current/ports/emulators/virtualbox-ose/Makefile Sat Jan 1 18:29:21 2011 --- new-generic/ports/emulators/virtualbox-ose/Makefile Sat Jan 1 18:32:19 2011 *************** *** 24,29 **** --- 24,37 ---- as86:${PORTSDIR}/devel/dev86 \ xsltproc:${PORTSDIR}/textproc/libxslt \ kmk:${PORTSDIR}/devel/kBuild + + # .if defined(DISPLAY) && ${DISPLAY} != "" + # BROKEN= "unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed: BadRequest (invalid request code or no such operation)" + # .endif + + CONFIGURE_ARGS+=--passive-mesa + # --passive-mesa To avoid: Checking for Mesa / GLU: X Error of failed: BadRequest (invalid request code or no such operation)" + LIB_DEPENDS= png.6:${PORTSDIR}/graphics/png \ xslt.2:${PORTSDIR}/textproc/libxslt \ curl.6:${PORTSDIR}/ftp/curl Cheers, Julian -- Julian H. Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com Mail plain text; Not quoted-printable, or HTML or base 64. Avoid top posting, it cripples itemised cumulative responses. -----------------------